Fix MotionStreak initializing and avoid trail delay by one frame #10982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1651819926515830.mp4非常抱歉，是我的锅，之前做的时候有发现这个问题，拖得有点久后来提交时就忘修复了 |
|
不知道是不是 github 的bug, 用 |
pandamicro
suggested changes
Jul 18, 2022
| @@ -92,14 +92,15 @@ export default class MotionStreakAssembler extends Assembler2D { | |||
| let stroke = comp._stroke / 2; | |||
|
|
|||
| let node = comp.node; | |||
| node._updateWorldMatrix(); | |||
| let matrix = node._worldMatrix.m; | |||
There was a problem hiding this comment.
let matrix = node.getWorldMatrix(cache_matrix);
This will ensure the matrix is always updated, and it avoid using private method
pandamicro
approved these changes
Jul 19, 2022
我都是用 `base:v2.4.` 进行模糊搜索 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #9693 cocos-creator-packages/jsb-adapter#368
Changelog: